fix(website): fix i18n routes for Canny board #5902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
added
pr: maintenance
|
✔️ [V2] 🔨 Explore the source changes: a735eeb 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6188aff49c4ea9000768f088 😎 Browse the preview: https://deploy-preview-5902--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5902--docusaurus-2.netlify.app/ |
|
Size Change: +124 B (0%) Total Size: 881 kB
ℹ️ View Unchanged
|
slorber
reviewed
Nov 9, 2021
| exact: false, | ||
| component: '@site/src/featureRequests/FeatureRequestsPage', | ||
| modules: { | ||
| basePath: './feature-requests-plugin/default/paths.json', |
There was a problem hiding this comment.
createData returns the module path, you don't need to hardcode it :)
There was a problem hiding this comment.
Haha, I never understood how these APIs work... I'll look deeper into how they're implemented and maybe improve the documentation on this😄
Josh-Cena
added
pr: documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Pass the base route as props so that canny can handle the route correctly.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tested locally with
yarn start --locale zh-Hansandhttps://localhost:3000/zh-Hans/feature-requestsis not redirected tohttps://localhost:3000/feature-requestsafter Canny loads.