Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refer to deployed branch as deployment rather than target #5903

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

The deployed branch should be called deployment branch because our API is called deploymentBranch; "target" is also not specific enough.

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 8, 2021
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 8, 2021
@netlify
Copy link

netlify bot commented Nov 8, 2021

✔️ [V2]

🔨 Explore the source changes: f86eb98

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6188be05cae569000792f6df

😎 Browse the preview: https://deploy-preview-5903--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 97
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5903--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Size Change: -3 B (0%)

Total Size: 881 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 38.2 kB 0 B
website/build/assets/css/styles.********.css 94 kB 0 B
website/build/assets/js/main.********.js 474 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 66.1 kB 0 B
website/build/blog/index.html 36.8 kB 0 B
website/build/docs/index.html 44 kB 0 B
website/build/docs/installation/index.html 51.5 kB -3 B (0%)
website/build/index.html 29.5 kB 0 B
website/build/tests/docs/index.html 25.2 kB 0 B
website/build/tests/docs/standalone/index.html 21.7 kB 0 B

compressed-size-action

@Josh-Cena Josh-Cena merged commit 13d07ef into main Nov 8, 2021
@Josh-Cena Josh-Cena deleted the jc/target-to-deployment branch November 8, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants