Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translate all remaining english sentence in French #5944

Merged
merged 1 commit into from Nov 14, 2021

Conversation

StanKocken
Copy link
Contributor

  • Update fr.json

Motivation

As stated within https://docusaurus.io/docs/i18n/tutorial, you ask:

Please help us complete those default translations.

As I just started to use you great tool, here is my little contribution

Have you read the Contributing Guidelines on pull requests?

I did.

Test Plan

Compiled and made sure the newly translate copy is displayed correctly.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 13, 2021
@netlify
Copy link

netlify bot commented Nov 13, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 3932575

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61901cb862c0fb00087dfd00

😎 Browse the preview: https://deploy-preview-5944--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 72
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5944--docusaurus-2.netlify.app/

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM👍

@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Nov 14, 2021
@Josh-Cena Josh-Cena merged commit 81ab250 into facebook:main Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants