Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types): correct HtmlTags types #5959

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Nov 16, 2021

Motivation

(Write your motivation here.)

Have you read the Contributing Guidelines on pull requests?

yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 16, 2021
@netlify
Copy link

netlify bot commented Nov 16, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: ebf5196

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61942bd2a9d54f000797bd61

😎 Browse the preview: https://deploy-preview-5959--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 98
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5959--docusaurus-2.netlify.app/

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you educate me a little on the difference? I thought the index signature is automatically a partial record since we don't have explicit undefined keys

@Josh-Cena Josh-Cena merged commit 3bf59a6 into facebook:main Nov 16, 2021
@armano2 armano2 deleted the chore/types-html-tags branch November 16, 2021 23:17
@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Nov 17, 2021
@Josh-Cena
Copy link
Collaborator

I kind of see it now. This is a type inference problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants