Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add NPM and PNPM to E2E tests #6080

Merged
merged 4 commits into from
Dec 10, 2021
Merged

chore: add NPM and PNPM to E2E tests #6080

merged 4 commits into from
Dec 10, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

After this peer dependency incident (and previously #5803), let's add NPM & PNPM to our E2E matrix.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

CI

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Dec 10, 2021
@netlify
Copy link

netlify bot commented Dec 10, 2021

✔️ [V2]

🔨 Explore the source changes: 0298008

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61b2a5ff14b2c200075778e0

😎 Browse the preview: https://deploy-preview-6080--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 10, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 67
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6080--docusaurus-2.netlify.app/

@github-actions

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants