Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content-blog): support json feed #6126

Merged
merged 7 commits into from
Dec 18, 2021

Conversation

notzheng
Copy link
Contributor

Motivation

Support to generate json feed of blog posts.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

Add test case for generating json feed.

Related PRs

None

@netlify
Copy link

netlify bot commented Dec 18, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: db0272d

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61bdefbbb83d480009b200a8

😎 Browse the preview: https://deploy-preview-6126--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 18, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 81
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6126--docusaurus-2.netlify.app/

@Josh-Cena
Copy link
Collaborator

Thanks. I'd rather make it opt-in as we have stated in our docs that RSS & Atom are generated by default (which IMO is already a little too much—I'd rather only generate RSS unless otherwise stated). Apart from that, LGTM👍

Made some refactors. If you don't have anything further to add, we can merge this

@Josh-Cena Josh-Cena added the pr: new feature This PR adds a new API or behavior. label Dec 18, 2021
@notzheng
Copy link
Contributor Author

Thanks. I'd rather make it opt-in as we have stated in our docs that RSS & Atom are generated by default (which IMO is already a little too much—I'd rather only generate RSS unless otherwise stated). Apart from that, LGTM👍

Made some refactors. If you don't have anything further to add, we can merge this

Thanks for your advice and refactors.

@Josh-Cena Josh-Cena merged commit 7e5f6bb into facebook:main Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants