Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ideal-image): allow translating status messages #6173

Merged
merged 8 commits into from
Dec 28, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

#4542

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: new feature This PR adds a new API or behavior. label Dec 23, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 23, 2021
@netlify
Copy link

netlify bot commented Dec 23, 2021

✔️ [V2]

🔨 Explore the source changes: 49ec999

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61cb03a74b98f000086938e2

😎 Browse the preview: https://deploy-preview-6173--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 23, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 67
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6173--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Dec 23, 2021

Size Change: 0 B

Total Size: 667 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 40.1 kB
website/build/assets/css/styles.********.css 102 kB
website/build/assets/js/main.********.js 496 kB
website/build/index.html 29.6 kB

compressed-size-action

@Josh-Cena Josh-Cena changed the title feat(ideal-image): allow translating ideal image messages feat(ideal-image): allow translating status messages Dec 23, 2021
@Josh-Cena Josh-Cena added the status: awaiting review This PR is ready for review, will be merged after maintainers' approval label Dec 23, 2021
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

probably not too interesting to invest a lot of time on this component, someday we'll probably have to rewrite it from scratch

@Josh-Cena
Copy link
Collaborator Author

someday we'll probably have to rewrite it from scratch

Oh well, that's not something I had a plan for... Maybe we do need to change the Webpack setup so other image loaders work with this, but the component can probably stay

@Josh-Cena Josh-Cena removed the status: awaiting review This PR is ready for review, will be merged after maintainers' approval label Dec 28, 2021
@Josh-Cena Josh-Cena merged commit e067ce7 into main Dec 28, 2021
@Josh-Cena Josh-Cena deleted the jc/translate-ideal-image branch December 28, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants