Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme-classic): usable CodeBlock outside markdown #6216

Merged
merged 3 commits into from
Dec 29, 2021
Merged

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Close #6185

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

@Josh-Cena Josh-Cena added the pr: new feature This PR adds a new API or behavior. label Dec 29, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 29, 2021
@netlify

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Dec 29, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 66
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6216--docusaurus-2.netlify.app/

@netlify
Copy link

netlify bot commented Dec 29, 2021

✔️ [V2]

🔨 Explore the source changes: 5d14ce4

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61cc5a08ad1f9b0007f087cc

😎 Browse the preview: https://deploy-preview-6216--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 29, 2021

Size Change: -5 B (0%)

Total Size: 667 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 40.1 kB 0 B
website/build/assets/css/styles.********.css 102 kB 0 B
website/build/assets/js/main.********.js 496 kB -5 B (0%)
website/build/index.html 29.6 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Dec 29, 2021

LGTM 👍 thanks

@slorber slorber merged commit c45281a into main Dec 29, 2021
@slorber slorber deleted the jc/jsx-codeblock branch December 29, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeBlock in React pages
3 participants