refactor(theme-translations): improve typing for update script #6225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
added
the
pr: maintenance
Josh-Cena
force-pushed
the
jc/better-update
branch
from
c0b33df
to
82ad95f
Compare
|
✔️ [V2] 🔨 Explore the source changes: 98ed514 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61cd78c0e898a1000839d906 😎 Browse the preview: https://deploy-preview-6225--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6225--docusaurus-2.netlify.app/ |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6225--docusaurus-2.netlify.app/ |
|
Size Change: 0 B Total Size: 669 kB ℹ️ View Unchanged
|
|
✔️ [V2] 🔨 Explore the source changes: 82ad95f 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61cd792e4b98f0000897094f 😎 Browse the preview: https://deploy-preview-6225--docusaurus-2.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now we don't need to do
-e require().run()which looks inelegantHave you read the Contributing Guidelines on pull requests?
Yes