fix(create-docusaurus): add useBaseUrl for image URLs

[alias-mac]

Motivation

This is already provided by the classic template and in TypeScript template wasn't updated.
Based on the documentation it is better to use useBaseUrl and I don't see the benefit of repeating the same function call in the FeatureList array.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Without this change it looks like this:

With the change applied the images load correctly:

[facebook-github-bot]

Hi @alias-mac!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[Josh-Cena]

Thanks! We also have some links that are not using useBaseUrl. Could you update them as well?

[netlify]

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 5080857

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61e23fcc115705000772cddc

😎 Browse the preview: https://deploy-preview-6368--docusaurus-2.netlify.app

[alias-mac]

@Josh-Cena can you clarify which links are missing the useBaseUrl? All the links on the docs template seem to be working for me (when using a context). Also yarn build doesn't report broken links. What am I missing?

[Josh-Cena]

Oh, I realized that links automatically have base URL prepended :D Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[github-actions]

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟠 Performance	85
🟢 Accessibility	98
🟢 Best practices	93
🟢 SEO	100
🟢 PWA	92

Lighthouse ran on https://deploy-preview-6368--docusaurus-2.netlify.app/