Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logger): properly stringify objects for logging #6384

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Still logging [object Object]... Need a better fix

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

TODO

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Jan 17, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 17, 2022
@netlify
Copy link

netlify bot commented Jan 17, 2022

✔️ [V2]

🔨 Explore the source changes: ddeb702

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61e5621b40882200080fafc2

😎 Browse the preview: https://deploy-preview-6384--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jan 17, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 70
🟢 Accessibility 98
🟢 Best practices 93
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6384--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Jan 17, 2022

Size Change: 0 B

Total Size: 678 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 42.9 kB
website/build/assets/css/styles.********.css 103 kB
website/build/assets/js/main.********.js 503 kB
website/build/index.html 29.6 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit a9810db into main Jan 17, 2022
@Josh-Cena Josh-Cena deleted the jc/fix-log branch January 17, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants