Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cSpell for spell checking #6456

Merged
merged 11 commits into from Jan 25, 2022
Merged

chore: add cSpell for spell checking #6456

merged 11 commits into from Jan 25, 2022

Conversation

nschonni
Copy link
Contributor

Motivation

Used cspell --no-progress --words-only --unique "**" > project-words.txt to create a base dictionary after ignoring some of the files that added in a bunch of one-off words in the users.txt and the translations

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 24, 2022
@netlify
Copy link

netlify bot commented Jan 24, 2022

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: a741563

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61ef5290366fec0008f80bb6

😎 Browse the preview: https://deploy-preview-6456--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jan 24, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 80
🟢 Accessibility 100
🟢 Best practices 93
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6456--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena added meta Meta-issue about the project itself. Either project maintenance or a list of other issues. pr: maintenance This PR does not produce any behavior differences to end users when upgrading. and removed meta Meta-issue about the project itself. Either project maintenance or a list of other issues. labels Jan 24, 2022
@@ -22,6 +22,8 @@ jobs:
- name: Check immutable yarn.lock
run: git diff --exit-code
- name: Lint
run: yarn lint:ci
run: |
echo "::add-matcher::.github/workflows/cspell-problem-matcher.json"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an aside, we haven't seen eslint error matchers for a long time. Maybe that's a problem with our setup-node config?

project-words.txt Outdated Show resolved Hide resolved
@Josh-Cena Josh-Cena changed the title chore: Add cSpell for spell checking chore: add cSpell for spell checking Jan 24, 2022
.cspell.json Show resolved Hide resolved
.cspell.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is starting to look great! Huge anticipations for a much more polished codebase in the near future

Signed-off-by: Joshua Chen <sidachen2003@gmail.com>
@Josh-Cena Josh-Cena merged commit 521eb11 into facebook:main Jan 25, 2022
@nschonni nschonni deleted the cspell branch January 25, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants