feat(theme-classic): add stable class for DocSidebarContainer #6466
Conversation
homotechsual
requested review from
Josh-Cena,
lex111 and
slorber
as code owners
|
Hi @homotechsual! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
homotechsual
changed the title
|
✔️ [V2] 🔨 Explore the source changes: 7b1ce36 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61f0ae9cc5e2b000073eda21 😎 Browse the preview: https://deploy-preview-6466--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6466--docusaurus-2.netlify.app/ |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Josh-Cena
changed the title
| @@ -5,21 +5,21 @@ | |||
| * LICENSE file in the root directory of this source tree. | |||
| */ | |||
|
|
|||
| import React, {type ReactNode, useState, useCallback} from 'react'; | |||
| import {MDXProvider} from '@mdx-js/react'; | |||
| import React, { type ReactNode, useState, useCallback } from 'react'; | |||
There was a problem hiding this comment.
This is weird. Does your editor's formatter not respect the .prettierrc file?
There was a problem hiding this comment.
Generally yes, but it appears not to have in this instance. It may be the dev containers interfering. I'll reset that back :-)
homotechsual
force-pushed
the
sidebarthemeclass
branch
from
5f1149f
to
7b1ce36
Compare
|
Should be good now @Josh-Cena - apologies for that. Still not entirely sure why it used default prettier rules but fixed now and it uses the right rules! |
Motivation
Currently styling the docs sidebar requires use of wildcard selectors to work with the generated id e.g:
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tested locally to ensure class applies. No linting errors introduced.
Related PRs
None/NA