Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Resoto & Some Engineering Inc. to showcase #6624

Merged
merged 2 commits into from
Feb 7, 2022
Merged

docs: add Resoto & Some Engineering Inc. to showcase #6624

merged 2 commits into from
Feb 7, 2022

Conversation

TheCatLady
Copy link
Contributor

Motivation

Over the past few weeks, I've used Docusaurus to set up the Some Engineering Inc. and Resoto websites. It would be a great honor to have them displayed in the Docusaurus showcase!

P.S.- I hope it's not too pretentious/arrogant of me to apply the design label to these two sites, but I did do more than just change colors, and plan to continue improving/customizing the designs! 馃槉

Have you read the Contributing Guidelines on pull requests?

Yup!

Test Plan

Built and verified locally.

@netlify
Copy link

netlify bot commented Feb 6, 2022

鉁旓笍 [V2]
Built without sensitive environment variables

馃敤 Explore the source changes: db02019

馃攳 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/620094faeca05f000834b024

馃槑 Browse the preview: https://deploy-preview-6624--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 6, 2022

鈿★笍 Lighthouse report for the changes in this PR:

Category Score
馃煚 Performance 89
馃煝 Accessibility 100
馃煝 Best practices 100
馃煝 SEO 100
馃煝 PWA 92

Lighthouse ran on https://deploy-preview-6624--docusaurus-2.netlify.app/

@Josh-Cena
Copy link
Collaborator

Seems you haven't enabled allow edits from maintainers... I do want to make minor edits to your PR 馃 Maybe enable it now and also for the future?

@TheCatLady
Copy link
Contributor Author

Seems you haven't enabled allow edits from maintainers... I do want to make minor edits to your PR 馃 Maybe enable it now and also for the future?

Enabled!

@Josh-Cena
Copy link
Collaborator

Great, thanks!

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Feb 7, 2022
@Josh-Cena Josh-Cena merged commit 032a1f0 into facebook:main Feb 7, 2022
@TheCatLady TheCatLady deleted the dh/showcase branch February 7, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants