feat(search-algolia): allow disabling search page and configuring path #6692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
added
the
feature
Josh-Cena
reviewed
Feb 16, 2022
packages/docusaurus-theme-search-algolia/src/validateThemeConfig.ts
Outdated
Show resolved
Hide resolved
|
✔️ [V2] 🔨 Explore the source changes: 5920411 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/620d18ceb99ab10008e33ab5 😎 Browse the preview: https://deploy-preview-6692--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6692--docusaurus-2.netlify.app/ |
Josh-Cena
added
pr: new feature
Josh-Cena
changed the title
|
Size Change: +47 B (0%) Total Size: 780 kB
ℹ️ View Unchanged
|
7 tasks
slorber
reviewed
Feb 16, 2022
packages/docusaurus-theme-search-algolia/src/validateThemeConfig.ts
Outdated
Show resolved
Hide resolved
Josh-Cena
reviewed
Feb 16, 2022
lex111
force-pushed
the
lex111/disable-search-page
branch
from
3e50531
to
eb4cc3b
Compare
slorber
reviewed
Feb 16, 2022
slorber
requested changes
Feb 16, 2022
packages/docusaurus-theme-search-algolia/src/theme-search-algolia.d.ts
Outdated
Show resolved
Hide resolved
|
Done. And yes, opensearch without the dedicated search page makes no sense. |
|
LGTM thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As was rightly pointed out earlier, the search page from the Algolia theme should be disableable like as well as its default path should be changeable.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Try to set
falsevalue foralgolia.searchPageto disable search page.Related PRs