Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add PcapPlusPlus to showcase #6837

Merged
merged 4 commits into from
Mar 4, 2022
Merged

docs: add PcapPlusPlus to showcase #6837

merged 4 commits into from
Mar 4, 2022

Conversation

seladb
Copy link
Contributor

@seladb seladb commented Mar 4, 2022

Motivation

I'm the maintainer of an open-source project named PcapPlusPlus. I recently migrated its website to Docusaurus 2.0: https://pcapplusplus.github.io/
I'd like to add this website to the Docusaurus Site Showcase.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

N/A

Related PRs

N/A

@facebook-github-bot
Copy link
Contributor

Hi @seladb!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@seladb
Copy link
Contributor Author

seladb commented Mar 4, 2022

I've signed the Facebook CLA:
image

@netlify
Copy link

netlify bot commented Mar 4, 2022

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 810f5db

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6221d903f360d70007379571

😎 Browse the preview: https://deploy-preview-6837--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 56
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6837--docusaurus-2.netlify.app/

@Josh-Cena
Copy link
Collaborator

Yeah, no problem, just wait for a few hours :)

As an aside, your navbar has multiple items lit up simultaneously:

image

My suggestion is to use multiple sidebars and use the docSidebar navbar item, or try the activeBaseRegex API

@seladb
Copy link
Contributor Author

seladb commented Mar 4, 2022

My suggestion is to use multiple sidebars and use the docSidebar navbar item, or try the activeBaseRegex API

Awesome, thank you for the tip, I'll fix that!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 4, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Josh-Cena Josh-Cena changed the title Add PcapPlusPlus to the Docusaurus Site Showcase docs: add PcapPlusPlus to showcase Mar 4, 2022
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 4, 2022
@Josh-Cena Josh-Cena merged commit 52fa451 into facebook:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants