Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): changelog plugin leads to CI bugs on release #6838

Merged
merged 3 commits into from
Mar 4, 2022

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Mar 4, 2022

Motivation

Will attempt to fix changelog bug happening after each new release: #6829 (comment)

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

ci

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 4, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 4, 2022
@netlify
Copy link

netlify bot commented Mar 4, 2022

✔️ [V2]

🔨 Explore the source changes: f038296

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6221e141768fc3000818d3b8

😎 Browse the preview: https://deploy-preview-6838--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 42
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6838--docusaurus-2.netlify.app/

@Josh-Cena
Copy link
Collaborator

Seems it's because the action builds the branch first, and then builds the branch's base. However, when running git reset, the newly generated changelog entry file is not removed, but the authors list is re-generated. I think the fix is to read authors.json first and only append extra entries.

@@ -8,7 +8,7 @@
"build": "docusaurus build",
"swizzle": "docusaurus swizzle",
"deploy": "docusaurus deploy",
"clear": "docusaurus clear",
"clear": "docusaurus clear && rimraf changelog",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this works as well 😄

@slorber
Copy link
Collaborator Author

slorber commented Mar 4, 2022

I believe it works but unfortunately, I can't verify this in current PR as it seems it executes the clean script of the main branch 😅

Will merge this assuming it works and open another PR to verify

@slorber slorber merged commit 3e38380 into main Mar 4, 2022
@slorber slorber deleted the slorber/fix-changelog-bug branch March 4, 2022 09:58
@slorber slorber mentioned this pull request Mar 4, 2022
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

Size Change: 0 B

Total Size: 791 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 597 kB
website/build/index.html 38.4 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants