-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(website): changelog plugin leads to CI bugs on release #6838
Conversation
✔️ [V2] 🔨 Explore the source changes: f038296 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6221e141768fc3000818d3b8 😎 Browse the preview: https://deploy-preview-6838--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6838--docusaurus-2.netlify.app/ |
Seems it's because the action builds the branch first, and then builds the branch's base. However, when running |
@@ -8,7 +8,7 @@ | |||
"build": "docusaurus build", | |||
"swizzle": "docusaurus swizzle", | |||
"deploy": "docusaurus deploy", | |||
"clear": "docusaurus clear", | |||
"clear": "docusaurus clear && rimraf changelog", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this works as well 😄
I believe it works but unfortunately, I can't verify this in current PR as it seems it executes the clean script of the main branch 😅 Will merge this assuming it works and open another PR to verify |
Size Change: 0 B Total Size: 791 kB ℹ️ View Unchanged
|
Motivation
Will attempt to fix changelog bug happening after each new release: #6829 (comment)
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
ci