Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary default values normalized during validation #6864

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

This should make the code clearer.

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 7, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 7, 2022
@netlify
Copy link

netlify bot commented Mar 7, 2022

✔️ [V2]

🔨 Explore the source changes: c98b9ef

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6225e8063de09400083b4b39

😎 Browse the preview: https://deploy-preview-6864--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 50
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6864--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

Size Change: -38 B (0%)

Total Size: 791 kB

Filename Size Change
website/build/assets/js/main.********.js 597 kB -38 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/index.html 38.4 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 8e93445 into main Mar 7, 2022
@Josh-Cena Josh-Cena deleted the jc/default-value branch March 7, 2022 11:23
@slorber
Copy link
Collaborator

slorber commented Mar 9, 2022

looks nice thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants