Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content-blog): remove double leading slash in blog-only paginated view #6918

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

heowc
Copy link
Contributor

@heowc heowc commented Mar 15, 2022

Motivation

Fix #6917

Have you read the Contributing Guidelines on pull requests?

Test Plan

Related PRs

@facebook-github-bot
Copy link
Contributor

Hi @heowc!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Mar 15, 2022
@Josh-Cena Josh-Cena changed the title fix(content-blog): Fix permalink function of paginateBlogPosts fix(content-blog): remove double leading slash in blog-only paginated view Mar 15, 2022
@netlify
Copy link

netlify bot commented Mar 15, 2022

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: bf69b23

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/623043ecaf0c9400083d7caa

😎 Browse the preview: https://deploy-preview-6918--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 15, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 57
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6918--docusaurus-2.netlify.app/

@heowc
Copy link
Contributor Author

heowc commented Mar 15, 2022

I signed the CLA. 🤣

@Josh-Cena
Copy link
Collaborator

Yeah, no worries. It would be updated within a few hours.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 15, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beacons are lit. Thanks a lot!

@Josh-Cena Josh-Cena merged commit 46b1027 into facebook:main Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pagination permalink includes pagination link double slash
3 participants