Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client-redirects): migrate validation to validateOptions lifecycle #6924

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Complete a TODO. We no longer rely on the default plugin ID.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Tests

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 16, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 16, 2022
@netlify
Copy link

netlify bot commented Mar 16, 2022

✔️ [V2]

🔨 Explore the source changes: db5bb08

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6232070f7f1c5f000819daf8

😎 Browse the preview: https://deploy-preview-6924--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 16, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 48
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6924--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Mar 16, 2022

Size Change: 0 B

Total Size: 792 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 599 kB
website/build/index.html 38.7 kB

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Mar 16, 2022

Thanks 👍 LGTM

@slorber slorber merged commit da9f38b into main Mar 16, 2022
@slorber slorber deleted the jc/redirect-validation branch March 16, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants