Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate Jest and website to SWC #6944

Merged
merged 2 commits into from
Mar 19, 2022
Merged

chore: migrate Jest and website to SWC #6944

merged 2 commits into from
Mar 19, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Jest and website now share the same infrastructure. Next step is to convert the MDX loader to use SWC for its transformation as well.

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 19, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 19, 2022
@netlify
Copy link

netlify bot commented Mar 19, 2022

✅ [V2]

🔨 Explore the source changes: b35d283

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6235cd98a416ac0009ce274e

😎 Browse the preview: https://deploy-preview-6944--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 19, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 44
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6944--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Mar 19, 2022

Size Change: +1.46 kB (0%)

Total Size: 805 kB

Filename Size Change
website/build/assets/js/main.********.js 612 kB +1.46 kB (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/index.html 38.8 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 19942f9 into main Mar 19, 2022
@Josh-Cena Josh-Cena deleted the jc/swc branch March 19, 2022 12:56
@slorber
Copy link
Collaborator

slorber commented Mar 23, 2022

nice

did you notice any perf improvement?

@Josh-Cena
Copy link
Collaborator Author

No, the perf was unimpressive. Jest still runs for ~9s (which is pretty fast anyways), and not sure how much is thanks to cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants