Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test coverage; reorder theme-common files #6956

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Discovered that a lot of un-covered files are because of our test coverage patterns... This commit bumps the test coverage to 86.53% functions 🎉

In addition, the theme-common files are getting messy. I reorganized them as components/hooks/contexts/utils.

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading. labels Mar 22, 2022
@netlify
Copy link

netlify bot commented Mar 22, 2022

✅ [V2]

🔨 Explore the source changes: ff60ab9

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/623977e3a7a56e00096d41bb

😎 Browse the preview: https://deploy-preview-6956--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 22, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 58
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6956--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Mar 22, 2022

Size Change: -71 B (0%)

Total Size: 805 kB

Filename Size Change
website/build/assets/js/main.********.js 612 kB -71 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/index.html 38.8 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 948271a into main Mar 22, 2022
@Josh-Cena Josh-Cena deleted the jc/test branch March 22, 2022 07:33
@slorber
Copy link
Collaborator

slorber commented Mar 23, 2022

I reorganized them as components/hooks/contexts/utils.

🤷‍♂️ this may not scale so well to group files by type

as long as the public API is the same I don't care too much about the current organization, so ok to give this a try

@Josh-Cena
Copy link
Collaborator Author

Those "contexts" that I extracted are pretty apparent as standalone contexts (one consumer + one provider). Grouping everything under utils is, let's just say, confusing. Let's hope this helps us split the files in a more manageable fashion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants