chore(types): remove querystring from dependencies

[Josh-Cena]

Motivation

Inspired by #6695

Have you read the Contributing Guidelines on pull requests?

Yes

[netlify]

✅ [V2]

🔨 Explore the source changes: e71d77f

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/62397ebc862b900008cd13df

😎 Browse the preview: https://deploy-preview-6957--docusaurus-2.netlify.app

[github-actions]

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟠 Performance	60
🟢 Accessibility	100
🟢 Best practices	92
🟢 SEO	100
🟢 PWA	90

Lighthouse ran on https://deploy-preview-6957--docusaurus-2.netlify.app/

[github-actions]

Size Change: 0 B

Total Size: 805 kB

ℹ️ View Unchanged

Filename	Size
website/.docusaurus/globalData.json	49.9 kB
website/build/assets/css/styles.********.css	105 kB
website/build/assets/js/main.********.js	612 kB
website/build/index.html	38.8 kB

_{compressed-size-action}

[netlify]

✅ [V2]

🔨 Explore the source changes: 613718d

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6239803e440ab000080b3143

😎 Browse the preview: https://deploy-preview-6957--docusaurus-2.netlify.app

[slorber]

@Josh-Cena for some weird reasons the CI does not complain but there's still one querystring usage in core code:

routes.ts:

import {stringify} from 'querystring';

function getModulePath(target: Module): string {
  if (typeof target === 'string') {
    return target;
  }
  const queryStr = target.query ? `?${stringify(target.query)}` : '';
  return `${target.path}${queryStr}`;
}

Should be easy to replace, let me know if you want to follow-up

[Josh-Cena]

That one is using the built-in querystring node module. You can run yarn why querystring to see which ones are pulling in the deprecated NPM module: currently it's only the SSG webpack plugin.

[slorber]

oh I see, didn't even know there was a built-in node module 😅