Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract MDX components #6989

Merged
merged 8 commits into from
Mar 24, 2022
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Mar 24, 2022

Motivation

Breaking change:

  • ul.contains-task-list CSS is now locally scoped instead of applied globally
  • <img> outside of markdown documents won't be auto-applied with height: auto: it is your responsibility to apply this in images of your Docusaurus pages if you want that CSS rule again, or to apply it back with a global CSS rule

Motivation

Make it easy to swizzle one specific component used to render MDX elements

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

preview

@slorber slorber added pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. pr: polish This PR adds a very minor behavior improvement that users will enjoy. labels Mar 24, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 24, 2022
@netlify
Copy link

netlify bot commented Mar 24, 2022

[V2]

Name Link
🔨 Latest commit 3929abc
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/623cb19b8fd5eb000843b2b9
😎 Deploy Preview https://deploy-preview-6989--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Mar 24, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 61
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6989--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Mar 24, 2022

Size Change: -5 B (0%)

Total Size: 805 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 49.9 kB 0 B
website/build/assets/css/styles.********.css 105 kB -5 B (0%)
website/build/assets/js/main.********.js 612 kB 0 B
website/build/index.html 38.3 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Mar 24, 2022

[V2]

Name Link
🔨 Latest commit cb2993e
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/623cb3577caab200086ce1a2
😎 Deploy Preview https://deploy-preview-6989--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants