Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split and cleanup theme/DocPage #7006

Merged
merged 6 commits into from
Mar 25, 2022
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Mar 25, 2022

Motivation

Smaller components, easier to swizzle and understand

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

preview works as before

@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Mar 25, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 25, 2022
@netlify
Copy link

netlify bot commented Mar 25, 2022

[V2]

Name Link
🔨 Latest commit 1cacd5e
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/623e086a01357c0008f569f7
😎 Deploy Preview https://deploy-preview-7006--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Mar 25, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 58
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7006--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Mar 25, 2022

Size Change: +79 B (0%)

Total Size: 806 kB

Filename Size Change
website/build/assets/js/main.********.js 612 kB +79 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/index.html 38.4 kB

compressed-size-action

@slorber
Copy link
Collaborator Author

slorber commented Mar 25, 2022

still not perfect but better than before 👍

@slorber slorber merged commit 1b974e8 into main Mar 25, 2022
@slorber slorber deleted the slorber/split-doc-page branch March 25, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants