Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: consistently use sidebars.js filename #7016

Merged
merged 2 commits into from
Mar 27, 2022

Conversation

leedom92
Copy link
Contributor

Motivation

sidebar.js should be modified to sidebars.js in some files

Have you read the Contributing Guidelines on pull requests?

Yes!

@facebook-github-bot
Copy link
Contributor

Hi @leedom92!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@Josh-Cena Josh-Cena changed the title Fix website sidebar docs: consistently use sidebars.js filename Mar 26, 2022
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 26, 2022
@netlify
Copy link

netlify bot commented Mar 26, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 757ce0b
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/623ed020b2de7f00084539bd
😎 Deploy Preview https://deploy-preview-7016--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Mar 26, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 58
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7016--docusaurus-2.netlify.app/

@leedom92 leedom92 closed this Mar 26, 2022
@Josh-Cena
Copy link
Collaborator

@leedom92 Why closing this?

@leedom92
Copy link
Contributor Author

@leedom92 Why closing this?

I thought the PR was not accepted,I reopen it right now.

@leedom92 leedom92 reopened this Mar 26, 2022
@Josh-Cena
Copy link
Collaborator

Just waiting for CLA. Have you signed it?

@leedom92
Copy link
Contributor Author

Just waiting for CLA. Have you signed it?

oh,thx! I had signed it just now.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 26, 2022
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Josh-Cena Josh-Cena merged commit b842197 into facebook:main Mar 27, 2022
@leedom92 leedom92 deleted the fix-website-sidebar branch March 27, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants