Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): reorganize functions #7037

Merged
merged 1 commit into from
Mar 28, 2022
Merged

refactor(core): reorganize functions #7037

merged 1 commit into from
Mar 28, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Make the code a lot clearer. More refactors to come—my goal is to make the main loading logic completely pure and context-free.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Tests and build

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 28, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 28, 2022
@netlify
Copy link

netlify bot commented Mar 28, 2022

[V2]

Name Link
🔨 Latest commit 22d8188
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62416b1949a7e80009634e58
😎 Deploy Preview https://deploy-preview-7037--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 55
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7037--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: +13 B (0%)

Total Size: 807 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 49.9 kB 0 B
website/build/assets/css/styles.********.css 105 kB 0 B
website/build/assets/js/main.********.js 613 kB 0 B
website/build/index.html 38.4 kB +13 B (0%)

compressed-size-action

@Josh-Cena Josh-Cena merged commit 85a79fd into main Mar 28, 2022
@Josh-Cena Josh-Cena deleted the jc/core-refactor branch March 28, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants