Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: install typedoc for generating API docs #7060

Closed
wants to merge 7 commits into from
Closed

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented Mar 29, 2022

Motivation

Close #6649. Since we have JSDoc, we can use TypeDoc to autogenerate these APIs.

I would investigate how we can make it emit nicer Markdown—probably need to eventually fork the plugin and make lots of customizations.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

https://deploy-preview-7060--docusaurus-2.netlify.app/docs/api-next

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 29, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 29, 2022
@Josh-Cena
Copy link
Collaborator Author

Josh-Cena commented Mar 29, 2022

cc @tgreyuk In case you are interested and have any suggestions. My ultimate goal is to emit Markdown that would very closely resemble our current documentation format, but the current output already looks far better than I expected!

@netlify
Copy link

netlify bot commented Mar 29, 2022

[V2]

Name Link
🔨 Latest commit d8e51ed
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/624325b62603ba000819d8c0
😎 Deploy Preview https://deploy-preview-7060--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Mar 29, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 61
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7060--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Mar 29, 2022

Size Change: +1.02 kB (0%)

Total Size: 812 kB

Filename Size Change
website/.docusaurus/globalData.json 51.3 kB +396 B (+1%)
website/build/assets/js/main.********.js 617 kB +626 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 105 kB 0 B
website/build/index.html 38.4 kB +1 B (0%)

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Apr 6, 2022

That looks interesting.

The problem is that most theme-common is currently not a public API surface.

If we document this officially on our website then users will start using internal APIs and we'll be in trouble.

@@ -120,7 +120,7 @@ export async function loadPluginConfigs(
// Site config should be the highest priority.
...standalonePlugins,
...standaloneThemes,
];
].filter(<T>(x: T | false | null | undefined): x is T => Boolean(x));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a change I think we could do and merge in another PR asap

I think we have an issue for it btw or it was discussed in the past

@Josh-Cena
Copy link
Collaborator Author

Ugh, looks too hard to maintain in the long run. Let's just hand-sync the docs instead.

@Josh-Cena Josh-Cena closed this Apr 15, 2022
@Josh-Cena Josh-Cena deleted the jc/typedoc branch April 15, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme protocol documentation
3 participants