Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: modify the description of deploying to Netlify #7796

Merged
merged 1 commit into from Jul 17, 2022
Merged

docs: modify the description of deploying to Netlify #7796

merged 1 commit into from Jul 17, 2022

Conversation

Oreoxmt
Copy link
Contributor

@Oreoxmt Oreoxmt commented Jul 17, 2022 •
edited

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

To keep consistency with the UI in Netlify:

  • modify build directory to publish directory
  • modify Build and deploy to Build & deploy

image

Test Plan

Test links

Deploy preview: https://deploy-preview-7796--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 17, 2022
Josh-Cena
Josh-Cena approved these changes Jul 17, 2022
View reviewed changes
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Jul 17, 2022
@netlify
Copy link

netlify bot commented Jul 17, 2022

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 3fa67c2
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62d3f73632234e00083a59c8
😎 Deploy Preview https://deploy-preview-7796--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 68 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 81 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena Josh-Cena merged commit fe3dfa7 into facebook:main Jul 17, 2022
dpang314 pushed a commit to dpang314/docusaurus that referenced this pull request Jul 24, 2022
@Oreoxmt @dpang314
docs: modify the description of deploying to Netlify (facebook#7796)
c3fbc21 
modify build directory to publish directory
This was referenced Oct 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Oreoxmt @Josh-Cena @facebook-github-bot