Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for React 18 :) #7855

Closed
wants to merge 1 commit into from

Conversation

sanjaiyan-dev
Copy link
Contributor

@sanjaiyan-dev sanjaiyan-dev commented Jul 31, 2022

Adding incremental support for React 18.

Extremely sorry if I made any mistakes :(

@Josh-Cena
Copy link
Collaborator

Please see #7102 and #7264. We have agreed to put this off till v3, and we have multiple dependencies blocking this, so now is not the time yet. Thanks for taking interest in this, but as the PR template (which you deleted) asked, please file an issue and get the maintainers' approval before working on any non-trivial change.

@Josh-Cena Josh-Cena closed this Jul 31, 2022
@Josh-Cena
Copy link
Collaborator

The main problem is that MDX v1 declares the same peer dependency range as we currently do. So if you use a package manager that's strict about peer dependency versions, you can't install React 18 successfully anyway (because MDX v1 blocks it); if you use one that's permissive, you should be able to use React 18 currently as well (as I have personally tried with Yarn).

@sanjaiyan-dev
Copy link
Contributor Author

Please see #7102 and #7264. We have agreed to put this off till v3, and we have multiple dependencies blocking this, so now is not the time yet. Thanks for taking interest in this, but as the PR template (which you deleted) asked, please file an issue and get the maintainers' approval before working on any non-trivial change.

I am extremely sorry :(

@Josh-Cena
Copy link
Collaborator

Nothing to be sorry about—feel free to comment under #7264 about what you are facing and what you think we should do :) AFAICT, users don't have any more or less difficulty migrating to React 18 regardless of what we do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants