fix(utils): always match exclusion root dirs as complete folder paths #7864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Josh-Cena
commented
Aug 1, 2022
| @@ -68,7 +69,7 @@ export function createAbsoluteFilePathMatcher( | |||
|
|
|||
| function getRelativeFilePath(absoluteFilePath: string) { | |||
| const rootFolder = rootFolders.find((folderPath) => | |||
| absoluteFilePath.startsWith(folderPath), | |||
| absoluteFilePath.startsWith(addTrailingSlash(folderPath)), | |||
There was a problem hiding this comment.
I'm unsure between addTrailingSlash and addTrailingPathSeparator. Tentatively went with addTrailingSlash; no one reported the bug before anyway so it won't be a regression
There was a problem hiding this comment.
OK, never mind: Windows tests tell me that addTrailingPathSeparator is the right one...
|
Size Change: 0 B Total Size: 812 kB ℹ️ View Unchanged
|
Josh-Cena
force-pushed
the
jc/fix-matcher
branch
from
93945d8
to
225c090
Compare
Josh-Cena
force-pushed
the
jc/fix-matcher
branch
from
9f1ac0c
to
ef18207
Compare
Josh-Cena
commented
Aug 1, 2022
Comment on lines
+72
to
+74
| [addSuffix(folderPath, '/'), addSuffix(folderPath, '\\')].some((p) => | ||
| absoluteFilePath.startsWith(p), | ||
| ), |
There was a problem hiding this comment.
Hacky but this will work for everyone. Remember that a single config may be used to build sites on both Windows and Unix, so we need to cater to 2×2 = 4 cases. I would merge like this.
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Issue surfaced in #7862
Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs