Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create): bad grammar in template docs #7978

Merged
merged 5 commits into from
Aug 25, 2022

Conversation

knownasnaffy
Copy link
Contributor

@knownasnaffy knownasnaffy commented Aug 19, 2022

Corrected grammar

Pre-flight checklist

Motivation

It didn't look good that such a nice tool has a grammar mistake in their preset 😅

Test Plan

Corrected grammar in translation docs page of classic-typescript preset.

Test links

Deploy preview: https://deploy-preview-7978--docusaurus-2.netlify.app/

Related issues/PRs

None

@facebook-github-bot
Copy link
Contributor

Hi @naffydharni006!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Aug 19, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit b665571
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/630767f16cb6da0008dba30f
😎 Deploy Preview https://deploy-preview-7978--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Aug 19, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 67 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 79 🟢 100 🟢 100 🟢 100 🟢 90 Report

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 19, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@knownasnaffy knownasnaffy changed the title docs: update classic-typescript preset Fix: update classic-typescript preset Aug 19, 2022
knownasnaffy and others added 3 commits August 20, 2022 09:38
Correct grammar

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Update translate-your-site.md to correct grammar
@Josh-Cena Josh-Cena changed the title Fix: update classic-typescript preset fix(create): bad grammar in template docs Aug 25, 2022
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Josh-Cena Josh-Cena merged commit ff8ef77 into facebook:main Aug 25, 2022
@knownasnaffy knownasnaffy deleted the patch-1 branch August 25, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants