Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add hyperlink to swizzling in Search page #8438

Merged
merged 2 commits into from Dec 14, 2022
Merged

Conversation

dandv
Copy link
Contributor

@dandv dandv commented Dec 13, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Those looking to evaluate Docusaurus's search capabilities, won't be familiar with swizzling.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 13, 2022
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 14, 2022
@slorber
Copy link
Collaborator

slorber commented Dec 14, 2022

Thanks

PR did not pass because links should rather use relative md file paths instead of relative paths: that makes them not sensitive to the presence of a trailingSlash

@netlify
Copy link

netlify bot commented Dec 14, 2022

[V2]

Name Link
🔨 Latest commit db86aa8
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/639a0784082c480009633752
😎 Deploy Preview https://deploy-preview-8438--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 57 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 77 🟢 100 🟢 100 🟢 100 🟢 90 Report

@slorber slorber changed the title docs: hyperlink swizzling in Search docs: add hyperlink to swizzling in Search page Dec 14, 2022
@slorber slorber merged commit 1c40d6c into facebook:main Dec 14, 2022
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants