Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade dependencies #8534

Merged
merged 3 commits into from
Jan 10, 2023
Merged

chore: upgrade dependencies #8534

merged 3 commits into from
Jan 10, 2023

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Due to the shear number of dependencies needing update, this PR only does minor/patch updates. All major updates go into a separate PR to avoid breaks as much as possible.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: dependencies Pull requests that update a dependency file label Jan 9, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 9, 2023
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Size Change: +185 B (0%)

Total Size: 890 kB

Filename Size Change
website/build/assets/js/main.********.js 666 kB +182 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 71 kB 0 B
website/build/assets/css/styles.********.css 112 kB -11 B (0%)
website/build/index.html 40.9 kB +14 B (0%)

compressed-size-action

@@ -31,6 +31,7 @@ const EXPECTED_CSS_MARKERS = [
// See https://github.com/facebook/docusaurus/pull/6222
'.markdown>h2',
'.button--outline.button--active',
'.DocSearch-Hit-content-wrapper',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some mysterious reason, this has reverted to pre-#8064 behavior

@netlify
Copy link

netlify bot commented Jan 9, 2023

[V2]

Name Link
🔨 Latest commit c688ec3
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63bda5fb2f25ee000859a9e1
😎 Deploy Preview https://deploy-preview-8534--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 94 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 83 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena
Copy link
Collaborator Author

cc @shortcuts We are getting these type checking failures:

Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(7,74): error TS2339: Property 'liteClient' does not exist on type 'typeof import("/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite")'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts([8](https://github.com/facebook/docusaurus/actions/runs/3878383730/jobs/6614488154#step:6:9),75): error TS2339: Property 'searchClient' does not exist on type 'typeof import("/home/runner/work/docusaurus/docusaurus/node_modules/@algolia/client-search/dist/client-search")'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(20,23): error TS26[9](https://github.com/facebook/docusaurus/actions/runs/3878383730/jobs/6614488154#step:6:10)4: Namespace '"/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite"' has no exported member 'LegacySearchMethodProps'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(24,23): error TS2694: Namespace '"/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite"' has no exported member 'SearchForFacetValuesResponse'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(28,23): error TS2694: Namespace '"/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite"' has no exported member 'SearchResponse'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(32,23): error TS2694: Namespace '"/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite"' has no exported member 'HighlightResult'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(36,23): error TS2694: Namespace '"/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite"' has no exported member 'SnippetResult'.

Does that look like a bug in the Algolia code base?

@shortcuts
Copy link
Contributor

oops it seems to be an upstream update that wasn't detected on the DocSearch side by renovate 🤔 releasing the update in 3.3.2

@shortcuts
Copy link
Contributor

update: fixed in 3.3.2

@Josh-Cena
Copy link
Collaborator Author

Thank you—that was really helpful!

@Josh-Cena Josh-Cena merged commit e8a0763 into main Jan 10, 2023
@Josh-Cena Josh-Cena deleted the update-deps branch January 10, 2023 18:23
@Josh-Cena Josh-Cena mentioned this pull request Jan 18, 2023
3 tasks
@Josh-Cena Josh-Cena added the to backport This PR is planned to be backported to a stable version of Docusaurus label Jan 18, 2023
@slorber slorber removed the to backport This PR is planned to be backported to a stable version of Docusaurus label Jan 26, 2023
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants