docs: add link to pluralization docs #8543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homotechsual
requested review from
slorber,
lex111 and
Josh-Cena
as code owners
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Josh-Cena
changed the title
Josh-Cena
reviewed
Jan 17, 2023
There was a problem hiding this comment.
I suggest de-noting this as a single sentence like:
The
<Translate>component supports interpolation. You can also implement string pluralization through some custom code.
Josh-Cena
added
the
pr: documentation
slorber
reviewed
Jan 19, 2023
website/docs/docusaurus-core.mdx
Outdated
| @@ -334,6 +334,12 @@ You can even omit the children prop and specify a translation string in your `co | |||
|
|
|||
| ::: | |||
|
|
|||
| :::info | |||
|
|
|||
| Your custom uses of `<Translate />` are also capable of handling [string pluralization](./i18n/i18n-tutorial.mdx#pluralization) | |||
There was a problem hiding this comment.
Suggested change
| Your custom uses of `<Translate />` are also capable of handling [string pluralization](./i18n/i18n-tutorial.mdx#pluralization) | |
| The `<Translate>` component supports [interpolation](#interpolate) and [pluralization](./i18n/i18n-tutorial.mdx#pluralization). |
edit: nop, bad suggestion
There was a problem hiding this comment.
Hmmm, do we really support pluralization when using <Translate>? Afaik we don't.
Also we probably need to apply selectMessage() before translating the content 😅 otherwise we translate string parts that we don't even use.
slorber
reviewed
Jan 20, 2023
slorber
approved these changes
Jan 20, 2023
slorber
reviewed
Jan 20, 2023
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Unsure on placement on this within the doc.