Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add mention that themeConfig.footer.copyright supports html strings #8761

Merged
merged 1 commit into from Mar 15, 2023

Conversation

fxpby
Copy link
Contributor

@fxpby fxpby commented Mar 12, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I want to configure copyright text to have some links, and via packages/docusaurus-theme-classic/src/theme/Footer/Copyright/index.tsx knew copyright supports the custom HTML, hope to add this description for docs.
And I had checked copyright alreadly supports the custom HTML in old version.

Test Plan

Test links

Deploy preview: https://deploy-preview-8761--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 12, 2023
@netlify
Copy link

netlify bot commented Mar 12, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit f4e3ac5
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/640e08a283d02800081d6bb9
😎 Deploy Preview https://deploy-preview-8761--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 90 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 84 🟢 100 🟢 100 🟢 100 🟢 90 Report

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 15, 2023
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks 👍

@slorber slorber merged commit ca86fab into facebook:main Mar 15, 2023
7 of 8 checks passed
@slorber slorber changed the title docs: add description for themeConfig.footer fields copyright docs: add mention that themeConfig.footer.copyright supports html strings Mar 15, 2023
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants