Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct small grammar error #8865

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Conversation

werner33
Copy link
Contributor

@werner33 werner33 commented Apr 4, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I came across a small grammatical error in the API documentation when looking into another issue. I've changed the existing wording from 'Do not open automatically the page in the browser' to 'Do not open the page automatically in the browser'.

Thanks!

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 4, 2023
@netlify
Copy link

netlify bot commented Apr 4, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit c048af3
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/642b98de6be4710008188628
😎 Deploy Preview https://deploy-preview-8865--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 56 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 75 🟢 100 🟢 100 🟢 100 🟢 90 Report

@@ -40,7 +40,7 @@ Builds and serves a preview of your site locally with [Webpack Dev Server](https
| `--port` | `3000` | Specifies the port of the dev server. |
| `--host` | `localhost` | Specify a host to use. For example, if you want your server to be accessible externally, you can use `--host 0.0.0.0`. |
| `--hot-only` | `false` | Enables Hot Module Replacement without page refresh as a fallback in case of build failures. More information [here](https://webpack.js.org/configuration/dev-server/#devserverhotonly). |
| `--no-open` | `false` | Do not open automatically the page in the browser. |
| `--no-open` | `false` | Do not open the page automatically in the browser. |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "Do not automatically open the page in the browser." sounds a bit more clear

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both look good to me, will keep current one for now

@slorber slorber changed the title fix(content-docs): correct small grammar error docs: correct small grammar error Apr 6, 2023
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 6, 2023
@slorber slorber merged commit 829a218 into facebook:main Apr 6, 2023
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants