Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken link to Prism includeLangs.js default list of languages #8904

Merged
merged 1 commit into from
May 12, 2023
Merged

docs: fix broken link to Prism includeLangs.js default list of languages #8904

merged 1 commit into from
May 12, 2023

Conversation

conlacda
Copy link
Contributor

@conlacda conlacda commented Apr 19, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I found a broken link, and I am making a pull request to fix it.

Test Plan

Just click on the new link.
Here is the broken link and here is the new corresponding link .

Test links

Not needed as this is just a docs change.

Related issues/PRs

None

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 19, 2023
@netlify
Copy link

netlify bot commented Apr 19, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 39835ab
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/643f5c99f7f1490008464904
😎 Deploy Preview https://deploy-preview-8904--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 88 🟢 97 🟢 92 🟢 100 🟢 90 Report
/docs/installation 🟠 84 🟢 100 🟢 92 🟢 100 🟢 90 Report

@slorber slorber changed the title docs: fix broken link docs: fix broken link to Prism includeLangs.js default list of languages Apr 19, 2023
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting.

Not 100% sure it's the correct replacement link

Also we need to fix older Docusaurus docs versions too ;)

By default, Docusaurus comes with a subset of [commonly used languages](https://github.com/FormidableLabs/prism-react-renderer/blob/master/src/vendor/prism/includeLangs.js).
By default, Docusaurus comes with a subset of [commonly used languages](https://github.com/FormidableLabs/prism-react-renderer/blob/master/packages/generate-prism-languages/index.ts).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's the proper replacement link (nor if it actually still exists). Waiting for an answer in FormidableLabs/prism-react-renderer#190

Old list: https://github.com/FormidableLabs/prism-react-renderer/blob/v1.3.0/src/vendor/prism/includeLangs.js

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 19, 2023
@slorber
Copy link
Collaborator

slorber commented Apr 20, 2023

fix #8910

@slorber slorber linked an issue Apr 20, 2023 that may be closed by this pull request
2 tasks
@slorber slorber merged commit 3170515 into facebook:main May 12, 2023
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link to Prism includeLangs.js default list of languages
3 participants