Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mdx-js is using v2 for next edition #8920

Merged
merged 1 commit into from Apr 26, 2023
Merged

Conversation

jhcao23
Copy link
Contributor

@jhcao23 jhcao23 commented Apr 24, 2023

mdx is using v2

@facebook-github-bot
Copy link
Contributor

Hi @jhcao23!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link

netlify bot commented Apr 24, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 8f532f4
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/644634c133cdee0008de7d8c
😎 Deploy Preview https://deploy-preview-8920--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 58 🟢 97 🟠 83 🟢 100 🟢 90 Report
/docs/installation 🟠 74 🟢 100 🟢 92 🟢 100 🟢 90 Report

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 25, 2023
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 26, 2023
@slorber slorber changed the title mdx-js is using v2 for next edition docs: mdx-js is using v2 for next edition Apr 26, 2023
@slorber
Copy link
Collaborator

slorber commented Apr 26, 2023

Thanks 👍

@slorber slorber merged commit 41f1c1e into facebook:main Apr 26, 2023
3 checks passed
@jhcao23 jhcao23 deleted the patch-1 branch April 28, 2023 04:02
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants