Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade TypeScript to v5.0 #8926

Merged
merged 1 commit into from Apr 25, 2023
Merged

chore: upgrade TypeScript to v5.0 #8926

merged 1 commit into from Apr 25, 2023

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

This version adds type defs for RegExpExecArray#indices, which I need.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 25, 2023
@Josh-Cena Josh-Cena added pr: dependencies Pull requests that update a dependency file and removed CLA Signed Signed Facebook CLA labels Apr 25, 2023
@netlify
Copy link

netlify bot commented Apr 25, 2023

[V2]

Name Link
🔨 Latest commit d439d1e
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6447778aeb85b500086e920b
😎 Deploy Preview https://deploy-preview-8926--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 94 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 87 🟢 100 🟢 92 🟢 100 🟠 89 Report

@github-actions
Copy link

Size Change: 0 B

Total Size: 1.01 MB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 101 kB
website/build/assets/css/styles.********.css 113 kB
website/build/assets/js/main.********.js 752 kB
website/build/index.html 41.3 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 1279765 into main Apr 25, 2023
29 checks passed
@Josh-Cena Josh-Cena deleted the upgrade-ts branch April 25, 2023 07:10
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 25, 2023
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants