Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: bidirectional link between api config and guide config #8950

Merged
merged 4 commits into from May 3, 2023
Merged

docs: bidirectional link between api config and guide config #8950

merged 4 commits into from May 3, 2023

Conversation

thadguidry
Copy link
Contributor

@thadguidry thadguidry commented Apr 29, 2023 •
edited by slorber

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Fixes part of #8925

Test Plan

Test links

https://deploy-preview-8950--docusaurus-2.netlify.app/docs/api/docusaurus-config/

https://deploy-preview-8950--docusaurus-2.netlify.app/docs/configuration/

Related issues/PRs

#8925

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 29, 2023
@netlify
Copy link

netlify bot commented Apr 29, 2023 •
edited

✅ [V2]

Name Link
🔨 Latest commit 3a0fb28
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6452907f6b43650008c4ada2
😎 Deploy Preview https://deploy-preview-8950--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 29, 2023 •
edited

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 83 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 88 🟢 100 🟢 92 🟢 100 🟠 89 Report

@thadguidry thadguidry mentioned this pull request Apr 29, 2023
Closed
2 tasks
@slorber slorber changed the title Link-apiconfig-to-configuration docs: bidirectional link between api config and guide config May 3, 2023
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label May 3, 2023
slorber
slorber approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@slorber slorber merged commit cf9fa2e into facebook:main May 3, 2023
8 of 9 checks passed
This was referenced Oct 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorber slorber slorber approved these changes

@lex111 lex111 Awaiting requested review from lex111

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thadguidry @slorber @facebook-github-bot