Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): better handling of code blocks in link replacement #9046

Merged
merged 1 commit into from Jun 8, 2023

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 7, 2023
@Josh-Cena Josh-Cena added pr: bug fix This PR fixes a bug in a past release. to backport This PR is planned to be backported to a stable version of Docusaurus labels Jun 7, 2023
@netlify
Copy link

netlify bot commented Jun 7, 2023

[V2]

Name Link
🔨 Latest commit 131b773
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/64805c39c227320008f1e9b3
😎 Deploy Preview https://deploy-preview-9046--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 91 🟢 97 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 81 🟢 100 🟢 100 🟢 100 🟠 89 Report

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Size Change: 0 B

Total Size: 1.01 MB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 101 kB
website/build/assets/css/styles.********.css 113 kB
website/build/assets/js/main.********.js 752 kB
website/build/index.html 41 kB

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Jun 8, 2023

Thanks 👍

Not a super fan of those string manipulations on which such edge cases have to be handled, we should try to adopt a more robust solution (#9048)

@slorber slorber merged commit 76f9203 into main Jun 8, 2023
29 of 30 checks passed
@slorber slorber deleted the fix-link-parsing branch June 8, 2023 10:16
This was referenced Oct 19, 2023
@slorber slorber removed the to backport This PR is planned to be backported to a stable version of Docusaurus label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong markdown prevents link to get parsed correctly
3 participants