Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update link for commonly used languages #9065

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

heysujal
Copy link
Contributor

@heysujal heysujal commented Jun 13, 2023

Pre-flight checklist

Motivation

The link to commonly used languages was broken.
Closes #9062

Test Plan

I found new link for supported languages from here https://github.com/FormidableLabs/prism-react-renderer#installation:~:text=includes%20a%20base%20set%20of%20languages

Test links

Affected Supported Lang Docs Page https://docusaurus.io/docs/markdown-features/code-blocks#supported-languages

Deploy preview: https://deploy-preview-9065--docusaurus-2.netlify.app/

Related issues/PRs

#9062

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 13, 2023
@netlify
Copy link

netlify bot commented Jun 13, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 3254d3e
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/64889a0d4d15440007a59c2d
😎 Deploy Preview https://deploy-preview-9065--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 73 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 77 🟢 100 🟢 92 🟢 100 🟠 89 Report

@heysujal
Copy link
Contributor Author

One thing I am doubtful about is when I am seeing the latest docs 2.4.0 on docusaurus the link to commonly used languages is broken. But when I go to edit using Edit this Page link at the bottom of the page it redirects me to

By default, Docusaurus comes with a subset of [commonly used languages](https://github.com/FormidableLabs/prism-react-renderer/blob/master/packages/generate-prism-languages/index.ts#L9-L23).
where the link is already updated.

then why it redirects to the wrong page on the docs page?

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jun 14, 2023
@slorber slorber changed the title update link for commonly used languages docs: update link for commonly used languages Jun 14, 2023
@slorber
Copy link
Collaborator

slorber commented Jun 14, 2023

Thanks

Editing always the upstream/latest docs is done on purpose so that we don't lose the update by not noticing you only updated the versioned copy. Most of the time it's a better default because we don't often create new docs pages.

CleanShot 2023-06-14 at 17 26 14@2x

@slorber slorber merged commit 117cbac into facebook:main Jun 14, 2023
10 checks passed
@heysujal heysujal deleted the supported-lang-fix branch July 24, 2023 06:54
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad link to prism-react-renderer's list of default languages
3 participants