Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix filenames in docs/swizzling.mdx #9074

Merged
merged 2 commits into from Jun 16, 2023
Merged

Conversation

shwaka
Copy link
Contributor

@shwaka shwaka commented Jun 16, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

In Swizzling | Docusaurus, the way to eject/wrap a theme component is explained together with Footer as an example. The command npm run swizzle @docusaurus/theme-classic Footer -- --eject actually creates src/theme/Footer/index.js (and related files), but it is src/theme/SomeComponent.js in the current docs.
In this PR, I replaced it with the actual one.

Note that I changed swizzling.mdx not only in docs/ but also versioned_docs/version-X.Y.Z/.

Test Plan

This is not a code change.

Deploy preview: https://deploy-preview-9074--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 16, 2023
@netlify
Copy link

netlify bot commented Jun 16, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 14f1ede
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/648bfb8a61d5c90008c79ea6
😎 Deploy Preview https://deploy-preview-9074--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 57 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 74 🟢 100 🟢 92 🟢 100 🟠 89 Report

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jun 16, 2023
@slorber slorber changed the title Fix filenames in docs/swizzling.mdx docs: fix filenames in docs/swizzling.mdx Jun 16, 2023
@slorber
Copy link
Collaborator

slorber commented Jun 16, 2023

Thanks 👍

@slorber slorber merged commit 48df4f1 into facebook:main Jun 16, 2023
10 of 11 checks passed
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants