Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Flightcontrol as a deployment option #9139

Merged
merged 6 commits into from
Jul 20, 2023
Merged

Conversation

ModupeD
Copy link
Contributor

@ModupeD ModupeD commented Jul 10, 2023

Added Flightcontrol as a docusaurus deployment option

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Flightcontrol allows users to deploy their Docusaurus project on AWS Fargate directly from their GitHub account.

Added Flightcontrol as a deployment option
@facebook-github-bot
Copy link
Contributor

Hi @ModupeD!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link

netlify bot commented Jul 10, 2023

[V2]

Name Link
🔨 Latest commit 09f4691
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/64b8ffa900c47a000821b485
😎 Deploy Preview https://deploy-preview-9139--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jul 10, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 61 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 81 🟢 100 🟢 92 🟢 100 🟠 89 Report

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 10, 2023
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Jul 16, 2023
@Josh-Cena Josh-Cena changed the title docs : Added Flightcontrol as a deployment option docs: add Flightcontrol as a deployment option Jul 16, 2023
@slorber
Copy link
Collaborator

slorber commented Jul 20, 2023

Thanks 👍

@slorber slorber merged commit f295e4f into facebook:main Jul 20, 2023
8 checks passed
@flybayer
Copy link

Hi @slorber, do you know why the docs website is not yet reflecting this new content?

@slorber
Copy link
Collaborator

slorber commented Aug 2, 2023

@flybayer our current deployment is stuck due to bugs in our i18n SaaS Crowdin.

It will be deployed when I'm able to fix it 😅 unfortunately they haven't fixed the bug yet and there's no easy workaround on my side apart from a major i18n deployment change.

slorber added a commit to VinceCYLiao/docusaurus that referenced this pull request Aug 3, 2023
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com>
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants