Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): change schema.org itemType prop urls from http to https #9184

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix(theme): change schema.org itemType prop urls from http to https #9184

merged 1 commit into from
Jul 28, 2023

Conversation

thedevwonder
Copy link
Contributor

@thedevwonder thedevwonder commented Jul 28, 2023 •
edited by slorber
Loading

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

fix #9181

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 28, 2023
@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jul 28, 2023
@Josh-Cena Josh-Cena changed the title fix: change http to https for itemType prop fix(theme): change http to https for itemType prop Jul 28, 2023
@thedevwonder thedevwonder mentioned this pull request Jul 28, 2023
Closed
7 tasks
Josh-Cena
Josh-Cena approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@netlify
Copy link

netlify bot commented Jul 28, 2023

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 715f521
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/64c3eea913e5d400087145b3
😎 Deploy Preview https://deploy-preview-9184--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 86 🟢 97 🟠 83 🟢 100 🟠 89 Report
/docs/installation 🟠 76 🟢 100 🟠 83 🟢 100 🟠 89 Report

@slorber slorber changed the title fix(theme): change http to https for itemType prop fix(theme): change schema.org itemType prop urls from http to https Jul 28, 2023
@slorber slorber merged commit e0bb39a into facebook:main Jul 28, 2023
31 of 32 checks passed
slorber pushed a commit to VinceCYLiao/docusaurus that referenced this pull request Aug 3, 2023
@thedevwonder @slorber
fix(theme): change schema.org itemType prop urls from http to https (f…
372321c 
…acebook#9184)
This was referenced Oct 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-https URLs http://schema.org/Blog and BlogPosting in classic theme
4 participants
@thedevwonder @Josh-Cena @slorber @facebook-github-bot