Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add the missing import logger statement #9210

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented Aug 7, 2023

Pre-flight checklist

Motivation

Add the missing statement so the example is more self-contained.

@Zenahr thanks for the issue, and FYI, the docs already start with this:

It exports a single object as default export: logger. logger has the following properties:

Which means it should be default-imported (and of course, with TS downleveling; it doesn't work with native ESM default importing).

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 7, 2023
@Josh-Cena Josh-Cena added to backport This PR is planned to be backported to a stable version of Docusaurus pr: documentation This PR works on the website or other text documents in the repo. labels Aug 7, 2023
@netlify
Copy link

netlify bot commented Aug 7, 2023

[V2]

Name Link
🔨 Latest commit bbb3ecb
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/64d162e724628f000878c546
😎 Deploy Preview https://deploy-preview-9210--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 86 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 74 🟢 100 🟢 92 🟢 100 🟠 89 Report

@Josh-Cena Josh-Cena merged commit 3e9648e into main Aug 7, 2023
32 of 33 checks passed
@Josh-Cena Josh-Cena deleted the logger-import branch August 7, 2023 21:41
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Size Change: 0 B

Total Size: 1.1 MB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 117 kB
website/build/assets/css/styles.********.css 113 kB
website/build/assets/js/main.********.js 830 kB
website/build/index.html 41.3 kB

compressed-size-action

@slorber slorber removed the to backport This PR is planned to be backported to a stable version of Docusaurus label Sep 20, 2023
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add simple example and import statement to logger API docs
3 participants