Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump devcontainer to Ubuntu 22.04 to resolve arm64 incompatibility #9245

Merged
merged 1 commit into from Aug 24, 2023

Conversation

AFRUITPIE
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Cloning Docusaurus into a dev container volume (explained in greater detail here) failed on arm64 devices like my Apple Silicon Mac:

Error fetching image details: No manifest found for mcr.microsoft.com/vscode/devcontainers/base:ubuntu-20.04.
Start: Run: docker pull mcr.microsoft.com/vscode/devcontainers/base:ubuntu-20.04
Looking up Docker credential helper for 'mcr.microsoft.com'.
ubuntu-20.04: Pulling from vscode/devcontainers/base
no matching manifest for linux/arm64/v8 in the manifest list entries

This chore updates the dev container config to 22.04 for arm64 support and switches to the new devcontainers images from the soon-to-be-archived vscode-dev-containers (microsoft/vscode-dev-containers#1762).

Test Plan

Test Plan is a bit tough to provide here since it's essentially an "it didn't work on my machine" situation. It does work on my machine now though ✨

If the maintainers have access to an Apple Silicon Mac or other arm64 machine, you can also verify for yourselves that the new dev container environment works by following Microsoft's guide and cloning my AFRUITPIE/docusaurus fork into a dev container volume.

Related issues/PRs

This issue only took a less time to debug and resolve than it would to create an issue, so I haven't created one. If the maintainers require one, I'm happy to create it.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 20, 2023
@netlify
Copy link

netlify bot commented Aug 20, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit f157ebb
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/64e166916af7a300082a371e
😎 Deploy Preview https://deploy-preview-9245--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 60 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 70 🟢 98 🟢 92 🟢 100 🟠 89 Report

@slorber slorber added Argos Add this label to run UI visual regression tests. See argos.yml GH action. pr: maintenance This PR does not produce any behavior differences to end users when upgrading. and removed Argos Add this label to run UI visual regression tests. See argos.yml GH action. labels Aug 24, 2023
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

It wasn't super clear to me where to find out this image string, but apparently it's from here: https://github.com/devcontainers/images/tree/main/src/base-ubuntu#using-this-image

@slorber slorber merged commit 17d3e60 into facebook:main Aug 24, 2023
8 of 10 checks passed
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants