Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-translations): add missing zh-Hans messages #9321

Merged
merged 1 commit into from Sep 28, 2023

Conversation

chudongvip
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

It is not fix a bug, just help translate default translates of language zh-Hans.

Test Plan

NO

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot
Copy link
Contributor

Hi @chudongvip!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link

netlify bot commented Sep 19, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit fb04fd4
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6508fbe2c5442d0007c1cb80
😎 Deploy Preview https://deploy-preview-9321--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 88 🟢 97 🟢 92 🟢 100 🔴 33 Report
/docs/installation 🟠 74 🟢 98 🟢 92 🟢 100 🟠 89 Report

@slorber slorber changed the title Update theme-common.json fix(theme-translations): add missing zh-Hans messages Sep 19, 2023
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Sep 19, 2023
@slorber
Copy link
Collaborator

slorber commented Sep 19, 2023

Thanks.

We need you to sign the CLA otherwise it's impossible to merge. (sometimes it can takes hours to report your signatures so we'll just have to wait)

@slorber
Copy link
Collaborator

slorber commented Sep 25, 2023

@chudongvip can you sign the CLA please?

Otherwise I'll have to close and let someone else submit a fix

@chudongvip
Copy link
Contributor Author

@chudongvip can you sign the CLA please?

Otherwise I'll have to close and let someone else submit a fix

Sure. I have signed the CLA just now. I'm sorry for not replying to you in time

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 28, 2023
@slorber
Copy link
Collaborator

slorber commented Sep 28, 2023

Thanks 👍

@slorber slorber merged commit a178654 into facebook:main Sep 28, 2023
29 of 30 checks passed
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants