Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-translations): complete and fix hungarian translations #9338

Merged
merged 2 commits into from
Sep 25, 2023
Merged

fix(theme-translations): complete and fix hungarian translations #9338

merged 2 commits into from
Sep 25, 2023

Conversation

la55u
Copy link
Contributor

@la55u la55u commented Sep 22, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Some translations were missing and some were just not the right way to say what it's meant to be

@facebook-github-bot
Copy link
Contributor

Hi @la55u!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link

netlify bot commented Sep 22, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 5b7dc20
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/650ef7ea8c18e900085f1bfe
😎 Deploy Preview https://deploy-preview-9338--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Sep 22, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 58 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 78 🟢 98 🟢 92 🟢 100 🟠 89 Report

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 22, 2023
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Sep 25, 2023
@slorber slorber changed the title chore: fix some minor hungarian translations fix(theme-translations): complete and fix hungarian translations Sep 25, 2023
@slorber
Copy link
Collaborator

slorber commented Sep 25, 2023

thanks 👍

@slorber slorber merged commit 519428b into facebook:main Sep 25, 2023
30 of 31 checks passed
@la55u la55u deleted the patch-1 branch September 25, 2023 12:48
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants